Code review #137
Merged
Code review #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of Time.zone.today
eatplaynap
force-pushed
the
code-review
branch
from
9b2306d to
8697c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ご指摘いただいた箇所+途中で気づいたバグ修正(及びテスト)を追加しました。
レビューに対して
Time.zone.todayをDate.currentに変更バグ修正
Time.zone.todayとDate.currentの違いを調べている中で、アプリ全体にtimezoneが設定されていないため自動的にUTCに変換され、日本時間で午前0時〜午前8時59分の間に学習記録を作ると、前日の日付で学習記録が作られてしまうというバグを発見しました。ユーザーに合わせて動的にtimezoneを設定したいと考えているため、デフォルトはUTCのままにしておき、ブラウザからtimezoneの情報を取得し、cookieに保存し、学習記録作成のタイミングでtimezoneを変更するという処理を追加しました。
(参考: kbaum/browser-timezone-rails#45 (comment) )
バグ修正のためテストを追加しています。