Getscbatch bug?

[rica-carv]

Motivation and Context

I don't know if this intended or not, but the forced sc override trigger as true gives a "bug", forcing the class name to be plugin_myplugin_plugin_myplugin_overridenSCname_shortcode (yes, the two first sentence twice) & file name to be plugin_myplugin_overridenSCname_shortcode.php

I also would like to know what's the intended "override", since both override options won't really "override", they simply load the myplugin shortcode, without nothing from the original overriden plugin shortcode....

Description

Just changed the documentations next to the function because i don't know if this is the intended behaviour or not....

How Has This Been Tested?

Current github code of e107, and tested calling e107::getScBatch('corescname', 'mypluginscname', true);

The e107::getScBatch('corescname', 'mypluginscname', 'corescname'); call works as intended, overriding the corescname shortcode...

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[codeclimate]

Code Climate has analyzed commit acc8fa6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 38.9% (0.1% change).

View more on Code Climate.