Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_be_bytes to Scalar #152

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Add to_be_bytes to Scalar #152

merged 1 commit into from
Feb 13, 2025

Conversation

fed-franz
Copy link

@fed-franz fed-franz commented Feb 12, 2025 •
edited
Loading

Implements #151

@fed-franz fed-franz linked an issue Feb 12, 2025 that may be closed by this pull request
Add to_be_bytes to Scalar #151
Closed
@fed-franz fed-franz requested a review from moCello February 12, 2025 16:18
@fed-franz fed-franz self-assigned this Feb 12, 2025
@moCello moCello changed the title Add to be bytes Add to_be_bytes to Scalar Feb 12, 2025
moCello
moCello reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from separating the version bump changes from this PR, the changes LGTM

@fed-franz fed-franz marked this pull request as ready for review February 13, 2025 10:03
@fed-franz fed-franz force-pushed the add_to_be_bytes branch 2 times, most recently from cc8bfc6 to e840822 Compare February 13, 2025 12:19
@fed-franz fed-franz requested a review from moCello February 13, 2025 12:20
moCello
moCello approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fed-franz fed-franz merged commit 53b970e into master Feb 13, 2025
3 checks passed
@fed-franz fed-franz deleted the add_to_be_bytes branch February 13, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

Assignees

@fed-franz fed-franz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to_be_bytes to Scalar
2 participants
@fed-franz @moCello