Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataFrameDetectionReader to support Clutter vs. True Detections #1143

Open
mkierzenka opened this issue Mar 10, 2025 · 1 comment
Open

Comments

@mkierzenka
Copy link

Hello all, first time making a post here.
I have been using Stone Soup for a few months now- thank you for your efforts!

I see the support for Clutter Detections in the Simulators, which I think is a neat inclusion. But when I store simulated data into a Pandas DataFrame and read it back out, the DataFrameDetectionReader has no ability to return Clutter vs. True Detections (they are always just the generic Detection type). I store whether or not each detection is clutter as a field in my data frame and it would be helpful for playback to have the system natively return the proper type.

I would love to take a crack at implementing this, if that is okay. Perhaps by adding a Callable property on DataFrameDetectionReader that the user can override with a dict->boolean function that returns true for True Detections and false for Clutter Detections? Then DataFrameDetectionReader.detections_gen() could use that internally to create an object of the proper type. I would be sure to preserve the default behavior to what it is now, too.

Please let me know what you think!

@sdhiscocks
Copy link
Member

Hi @mkierzenka. Sounds like a useful feature, and contribution would be welcomed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants