Ignore generic type parameter names when matching #40359
+214
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic type parameter names are not significant to compat. �Remove these from the matching key, but make the ParameterName rule compare them.
dotnet-issue-labeler
bot
added
Area-ApiCompat
untriaged
ViktorHofer
reviewed
Apr 23, 2024
...Compatibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/CannotChangeParameterName.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 23, 2024
src/Compatibility/ApiCompat/Microsoft.DotNet.ApiCompatibility/Rules/MembersMustExist.cs
Show resolved
Hide resolved
ViktorHofer
reviewed
Apr 23, 2024
src/Compatibility/Microsoft.DotNet.ApiSymbolExtensions/SymbolExtensions.cs
Show resolved
Hide resolved
ViktorHofer
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic type parameter names are not significant to compat.
Remove these from the matching key, but make the
CannotChangeParameterNamerule compare them.