Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Even more) fix that/which grammar #11143

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren marked this pull request as ready for review March 28, 2025 19:55
@gewarren gewarren requested review from a team, Rick-Anderson, cston and 333fred as code owners March 28, 2025 19:55
Copy link

Learn Build status updates of commit 0361a30:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Build.Tasks.Windows/GenerateTemporaryTargetAssembly.xml ✅Succeeded View
xml/Microsoft.Build.Tasks.Windows/MarkupCompilePass1.xml ✅Succeeded View
xml/Microsoft.Build.Tasks.Windows/MarkupCompilePass2.xml ✅Succeeded View
xml/Microsoft.VisualBasic.FileIO/FileSystem.xml ✅Succeeded View
xml/Microsoft.VisualBasic.MyServices/RegistryProxy.xml ✅Succeeded View
xml/System.Activities.Hosting/WorkflowInstance.xml ✅Succeeded View
xml/System.Activities.Presentation.PropertyEditing/DialogPropertyValueEditor.xml ✅Succeeded View
xml/System.Activities.Presentation/ActivityDesigner.xml ✅Succeeded View
xml/System.Activities.Presentation/ContextItem.xml ✅Succeeded View
xml/System.Activities.Presentation/ObjectReferenceService.xml ✅Succeeded View
xml/System.Activities.Statements/State.xml ✅Succeeded View
xml/System.Activities/WorkflowInvoker.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CodeGenerator.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CompilerError.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/AdamInstance.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/AdamInstanceCollection.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/AdamRole.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/AdamRoleCollection.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/LdapConnection.xml ✅Succeeded View
xml/System.EnterpriseServices/ServiceConfig.xml ✅Succeeded View
xml/System.IdentityModel.Protocols.WSTrust/RequestClaim.xml ✅Succeeded View
xml/System.IdentityModel.Protocols.WSTrust/RequestedProofToken.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/Saml2SecurityTokenHandler.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/SamlSecurityTokenHandler.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/SecurityKeyType.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM. Let's :shipit:

@gewarren gewarren merged commit ad0a0a4 into dotnet:main Mar 31, 2025
5 checks passed
@gewarren gewarren deleted the that-which-iii branch March 31, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants