Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(More) fix that/which grammar #11142

Merged
merged 1 commit into from
Mar 31, 2025
Merged

(More) fix that/which grammar #11142

merged 1 commit into from
Mar 31, 2025

Conversation

gewarren
Copy link
Contributor

@github-actions github-actions bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 28, 2025
@gewarren gewarren marked this pull request as ready for review March 28, 2025 19:50
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 8680e37:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.ComponentModel.Design.xml ✅Succeeded View
xml/ns-System.Net.PeerToPeer.xml ✅Succeeded View
xml/ns-System.Runtime.InteropServices.Expando.xml ✅Succeeded View
xml/ns-System.ServiceProcess.xml ✅Succeeded View
xml/ns-System.Speech.Recognition.xml ✅Succeeded View
xml/ns-System.Threading.Tasks.xml ✅Succeeded View
xml/ns-System.Xml.Resolvers.xml ✅Succeeded View
xml/ns-System.Xml.xml ✅Succeeded View
xml/System.Linq.Expressions/BinaryExpression.xml ✅Succeeded View
xml/System.Linq.Expressions/Expression.xml ✅Succeeded View
xml/System.Linq.Expressions/LabelExpression.xml ✅Succeeded View
xml/System.Linq.Expressions/LambdaExpression.xml ✅Succeeded View
xml/System.Linq.Expressions/ListInitExpression.xml ✅Succeeded View
xml/System.Linq.Expressions/MemberInitExpression.xml ✅Succeeded View
xml/System.Linq.Expressions/UnaryExpression.xml ✅Succeeded View
xml/System.Linq/ParallelEnumerable.xml ✅Succeeded View
xml/System.Reflection.Emit/DynamicMethod.xml ✅Succeeded View
xml/System.Reflection/AmbiguousMatchException.xml ✅Succeeded View
xml/System.Reflection/AssemblyDelaySignAttribute.xml ✅Succeeded View
xml/System.Reflection/CustomAttributeFormatException.xml ✅Succeeded View
xml/System.Reflection/FieldInfo.xml ✅Succeeded View
xml/System.Reflection/InvalidFilterCriteriaException.xml ✅Succeeded View
xml/System.Reflection/ParameterInfo.xml ✅Succeeded View
xml/System.Reflection/PropertyInfo.xml ✅Succeeded View
xml/System.Reflection/TargetInvocationException.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit 640aa62 into dotnet:main Mar 31, 2025
5 checks passed
@gewarren gewarren deleted the that-which-ii branch March 31, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@StephenMolloy StephenMolloy Awaiting requested review from StephenMolloy StephenMolloy is a code owner

@HongGit HongGit Awaiting requested review from HongGit HongGit is a code owner

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT AaronRobinsonMSFT is a code owner

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky jkoritzinsky is a code owner

@cston cston Awaiting requested review from cston cston is a code owner

@333fred 333fred Awaiting requested review from 333fred 333fred is a code owner

Assignees

@gewarren gewarren

Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner