Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that/which grammar #11141

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Fix that/which grammar #11141

merged 2 commits into from
Mar 31, 2025

Conversation

gewarren
Copy link
Contributor

@github-actions github-actions bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 28, 2025
Copy link
Contributor

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

@gewarren gewarren marked this pull request as ready for review March 28, 2025 19:43
@gewarren gewarren requested a review from a team as a code owner March 28, 2025 19:43
@gewarren
Copy link
Contributor Author

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

This is for System.Numerics.Tensors and System.Formats.Asn1.

Copy link

Learn Build status updates of commit c179f71:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Specialized/HybridDictionary.xml ✅Succeeded View
xml/System.Collections.Specialized/NameObjectCollectionBase.xml ✅Succeeded View
xml/System.Collections.Specialized/NameValueCollection.xml ✅Succeeded View
xml/System.Collections/ArrayList.xml ✅Succeeded View
xml/System.Collections/Hashtable.xml ✅Succeeded View
xml/System.Diagnostics.Metrics/MeterListener.xml ✅Succeeded View
xml/System.Diagnostics/ActivityCreationOptions`1.xml ✅Succeeded View
xml/System.Diagnostics/DiagnosticSource.xml ✅Succeeded View
xml/System.Diagnostics/EventSchemaTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.Diagnostics/Switch.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnDecoder.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnReader.xml ✅Succeeded View
xml/System.Formats.Asn1/AsnWriter.xml ✅Succeeded View
xml/System.IO.Packaging/Package.xml ✅Succeeded View
xml/System.IO.Packaging/ZipPackage.xml ✅Succeeded View
xml/System.IO/BufferedStream.xml ✅Succeeded View
xml/System.IO/DirectoryNotFoundException.xml ✅Succeeded View
xml/System.IO/EndOfStreamException.xml ✅Succeeded View
xml/System.IO/FileNotFoundException.xml ✅Succeeded View
xml/System.IO/IOException.xml ✅Succeeded View
xml/System.IO/UnmanagedMemoryStream.xml ✅Succeeded View
xml/System.Numerics.Tensors/TensorPrimitives.xml ✅Succeeded View
xml/System.Numerics/BigInteger.xml ✅Succeeded View
xml/System.Numerics/BitOperations.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 0d74517 into dotnet:main Mar 31, 2025
5 checks passed
@gewarren
Copy link
Contributor Author

Thanks @BillWagner !!

@gewarren gewarren deleted the that-which branch March 31, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants