Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --recs arg to sozo build #3062

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

MartianGreed
Copy link
Contributor

@MartianGreed MartianGreed commented Feb 24, 2025

Summary by CodeRabbit

  • New Features
    • Added a command-line option to optionally include Recs bindings during the build process.

Copy link

coderabbitai bot commented Feb 24, 2025

Ohayo, sensei!

Walkthrough

A new boolean field recs has been added to the BuildArgs struct to support generating Recs bindings. The field is set to false by default and annotated with relevant command-line metadata. The run method now checks the recs flag and, if true, adds the BuiltinPlugins::Recs to the plugins vector, thereby modifying the control flow during the build process.

Changes

File Description
bin/sozo/.../build.rs Added new boolean recs field to BuildArgs with default value false. Updated the run method to conditionally push BuiltinPlugins::Recs.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as Command Line
    participant BA as BuildArgs
    participant PM as Plugin Manager
    CLI->>BA: Parse command-line arguments (including --recs)
    BA->>BA: Check if recs is true
    alt recs is true
        BA->>PM: Add BuiltinPlugins::Recs to plugins list
    else recs is false
        BA-->>PM: Proceed without adding Recs plugin
    end
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b93308 and 02f5bab.

📒 Files selected for processing (1)
  • bin/sozo/src/commands/build.rs (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: fmt
🔇 Additional comments (3)
bin/sozo/src/commands/build.rs (3)

29-31: Ohayo! New recs flag looks good, sensei!

The new flag follows the same pattern as other binding flags, with clear help text and proper command-line argument metadata.


215-215: Default value is properly set, sensei!

The recs flag is initialized to false by default, maintaining consistency with other binding flags.


125-127: Control flow modification looks perfect, sensei!

The implementation follows the established pattern of other binding flags, correctly adding the Recs plugin when enabled.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.49%. Comparing base (9b93308) to head (02f5bab).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
bin/sozo/src/commands/build.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3062   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files         439      439           
  Lines       59820    59825    +5     
=======================================
+ Hits        34392    34399    +7     
+ Misses      25428    25426    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 48cd046 into dojoengine:main Feb 26, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants