Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana): merging server args from file #3044

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions crates/katana/cli/src/args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ impl NodeArgs {

modules
};

Ok(RpcConfig {
apis: modules,
port: self.server.http_port,
Expand Down Expand Up @@ -386,11 +387,7 @@ impl NodeArgs {

#[cfg(feature = "server")]
{
if self.server == ServerOptions::default() {
if let Some(server) = config.server {
self.server = server;
}
}
self.server.merge(config.server.as_ref());

if self.metrics == MetricsOptions::default() {
if let Some(metrics) = config.metrics {
Expand Down
40 changes: 39 additions & 1 deletion crates/katana/cli/src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
http_addr: DEFAULT_RPC_ADDR,
http_port: DEFAULT_RPC_PORT,
http_cors_origins: Vec::new(),
http_modules: Some(RpcModulesList::default()),
http_modules: None,

Check warning on line 146 in crates/katana/cli/src/options.rs

View check run for this annotation

Codecov / codecov/patch

crates/katana/cli/src/options.rs#L146

Added line #L146 was not covered by tests
max_event_page_size: DEFAULT_RPC_MAX_EVENT_PAGE_SIZE,
max_proof_keys: DEFAULT_RPC_MAX_PROOF_KEYS,
max_connections: None,
Expand All @@ -154,6 +154,44 @@
}
}

#[cfg(feature = "server")]
impl ServerOptions {
pub fn merge(&mut self, other: Option<&Self>) {
if let Some(other) = other {
if self.http_addr == DEFAULT_RPC_ADDR {
self.http_addr = other.http_addr;
}
if self.http_port == DEFAULT_RPC_PORT {
self.http_port = other.http_port;
}
if self.http_cors_origins.is_empty() {
self.http_cors_origins = other.http_cors_origins.clone();
}
if self.http_modules.is_none() {
self.http_modules = other.http_modules.clone();
}
if self.max_connections.is_none() {
self.max_connections = other.max_connections;
}
if self.max_request_body_size.is_none() {
self.max_request_body_size = other.max_request_body_size;
}
if self.max_response_body_size.is_none() {
self.max_response_body_size = other.max_response_body_size;
}
if self.max_event_page_size == DEFAULT_RPC_MAX_EVENT_PAGE_SIZE {
self.max_event_page_size = other.max_event_page_size;
}
if self.max_proof_keys == DEFAULT_RPC_MAX_PROOF_KEYS {
self.max_proof_keys = other.max_proof_keys;
}
if self.max_call_gas == DEFAULT_RPC_MAX_CALL_GAS {
self.max_call_gas = other.max_call_gas;
}

Check warning on line 190 in crates/katana/cli/src/options.rs

View check run for this annotation

Codecov / codecov/patch

crates/katana/cli/src/options.rs#L161-L190

Added lines #L161 - L190 were not covered by tests
}
}
}

#[derive(Debug, Args, Clone, Serialize, Deserialize, Default, PartialEq)]
#[command(next_help_heading = "Starknet options")]
pub struct StarknetOptions {
Expand Down
Loading