Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper-case primitive from DocuSign API causes fatal error #180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trickeyone
Copy link

Proper-case primitive returned from DocuSign API causes fatal error

Fatal Error (1): Class 'Number' not found in [/path/to/app/vendor/docusign/esign-client/src/ObjectSerializer.php, line 274]

Replaces #41. Branched from current master with only type changes.

@trickeyone
Copy link
Author

Looks like the checks are failing due to an outdated version of PHPUnit.

PHP Deprecated:  The each() function is deprecated. This message will be suppressed on further calls in /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/Util/Getopt.php on line 38
PHP Stack trace:
PHP   1. {main}() /path/to/project//docusign-php-client/vendor/bin/phpunit:0
PHP   2. include() /path/to/project//docusign-php-client/vendor/bin/phpunit:115
PHP   3. PHPUnit_TextUI_Command::main() phpvfscomposer:///path/to/project//docusign-php-client/vendor/phpunit/phpunit/phpunit:51
PHP   4. PHPUnit_TextUI_Command->run() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:100
PHP   5. PHPUnit_TextUI_Command->handleArguments() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:111
PHP   6. PHPUnit_Util_Getopt::getopt() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:240
PHP   7. each() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/Util/Getopt.php:38

Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/Util/Getopt.php on line 38

Call Stack:
    0.0010     412656   1. {main}() /path/to/project//docusign-php-client/vendor/bin/phpunit:0
    0.0036     419632   2. include('phpvfscomposer:///path/to/project//docusign-php-client/vendor/phpunit/phpunit/phpunit') /path/to/project//docusign-php-client/vendor/bin/phpunit:115
    0.0121     899416   3. PHPUnit_TextUI_Command::main() phpvfscomposer:///path/to/project//docusign-php-client/vendor/phpunit/phpunit/phpunit:51
    0.0121     899528   4. PHPUnit_TextUI_Command->run() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:100
    0.0121     899528   5. PHPUnit_TextUI_Command->handleArguments() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:111
    0.0127     925752   6. PHPUnit_Util_Getopt::getopt() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/TextUI/Command.php:240
    0.0127     926192   7. each() /path/to/project//docusign-php-client/vendor/phpunit/phpunit/src/Util/Getopt.php:38

PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

@trickeyone
Copy link
Author

I have a fix available that upgrades to PHPUnit 9 with minimal changes. If desired, I can push this commit here as well.

@trickeyone
Copy link
Author

Tests are now failing because the Travis CI job is missing environment variables that are only configured for the main master branch's build. Is there a way to configure these so the check can be properly run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant