Misc UI and bug fixes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsick
reviewed
Jul 12, 2024
There was a problem hiding this comment.
The current nav-pills was a dirty interim solution, but the duplicate can be hidden for now with sites that have the admin sidebar turned off
There was a problem hiding this comment.
Ahh, ok. So should would you say we should not include this change then, and handle it on a site by site basis for now?
carsick
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Are you testing the Ad Plugin on your local instance?
There was a problem hiding this comment.
No, I actually haven't used it at all. 😁 I was just seeing this text rendered on SambaNova's staging and it apparently comes from the ad plugin. I don't know why that particular text is showing up as an 'ad', though! I just thought it would look better with some added space.
carsick
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sticky Sidebar - Fix Scrolling Bug
There was an issue when the sidebar was taller than the page content. Upon reaching the bottom, the sidebar would be set to fixed position, causing a layout glitch. Added a check to only change the sidebar position if we haven't reached the bottom of the page (in which case the rest of the page should keep scrolling while the sidebar is fixed).
Sign Up Button - Border Radius
Admin / Preferences - Add Padding
Admin Interface - Remove Duplicate Nav Controls
User Menu - Fix Bookmarks Link
Timeline - Add Top Margin