DEV: Review theme and refactor js #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsick
reviewed
Jul 10, 2024
| @@ -123,11 +120,7 @@ export default class BlockTopContributors extends Component { | |||
| href={{concat "/u/" topContributor.username}} | |||
| data-user-card={{topContributor.username}} | |||
| > | |||
| {{!-- {{#if topContributor.name}} | |||
There was a problem hiding this comment.
This was kept in in case the option to prioritize names should exist.
CvX
reviewed
Jul 10, 2024
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Grubba27
commented
Jul 11, 2024
Comment on lines
+33
to
+34
| const response = await fetch(`/categories.json?page=${page}`); // why not ajax? | ||
| const data = await response.json(); |
There was a problem hiding this comment.
@carsick, could this be changed to an Ajax?
CvX
reviewed
Jul 13, 2024
CvX
approved these changes
Jul 22, 2024
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few questions and todos left, but we can discuss and close them as we go.
Todos
Maybe we have a loading state in:
/components/blocks/birthday.gjscode/components/blocks/online.gjscodeUse
ajaxinstead of fetch innavigation.gjscodeadd tests?