Fix transmute #30

diondokter · 2024-12-26T15:16:26Z

Fixes #29

@rabarar could you try this out to see if it compiles for you now?

rabarar · 2024-12-26T15:37:11Z

switch to fix-transmute branch, cleaned and rebuilt:

error[E0432]: unresolved import `nrf_modem::no_std_net`
 --> src/main.rs:10:17
  |
10 | use nrf_modem::{no_std_net::SocketAddr, ConnectionPreference, LteLink, SystemMode, TcpStream};
  |                 ^^^^^^^^^^ could not find `no_std_net` in `nrf_modem`

error[E0425]: cannot find function `application_irq_handler` in crate `nrf_modem`
 --> src/main.rs:33:20
  |
33 |         nrf_modem::application_irq_handler();
  |                    ^^^^^^^^^^^^^^^^^^^^^^^ not found in `nrf_modem`

warning: unused import: `core::str::FromStr`
--> src/main.rs:5:5
 |
5 | use core::str::FromStr;
 |     ^^^^^^^^^^^^^^^^^^
 |
 = note: `#[warn(unused_imports)]` on by default

error: item does not constrain `Fut::{opaque#0}`, but has it in its signature
 --> src/main.rs:16:1
  |
16 | #[embassy_executor::main]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: consider moving the opaque type's declaration and defining uses into a separate module
note: this opaque type is in the signature
 --> src/main.rs:16:1
  |
16 | #[embassy_executor::main]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^
  = note: this error originates in the attribute macro `::embassy_executor::task` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0425, E0432.
For more information about an error, try `rustc --explain E0425`.
warning: `nrf9160-rust-starter` (bin "nrf9160-rust-starter") generated 1 warning
error: could not compile `nrf9160-rust-starter` (bin "nrf9160-rust-starter") due to 3 previous errors; 1 warning emitted

rabarar · 2024-12-26T17:20:14Z

I’m going to create a parallel environment on a ARM vm using ubuntu-24.10 server … stay tuned …

…

rabarar · 2024-12-26T17:32:16Z

Linux build:

cargo +nightly -vV:

cargo 1.85.0-nightly (c86f4b3a1 2024-12-24)
release: 1.85.0-nightly
commit-hash: c86f4b3a1b153218e6e50861214b0b4b4e695f23
commit-date: 2024-12-24
host: aarch64-unknown-linux-gnu
libgit2: 1.8.1 (sys:0.19.0 vendored)
libcurl: 8.9.0-DEV (sys:0.4.74+curl-8.9.0 vendored ssl:OpenSSL/1.1.1w)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Ubuntu 24.10.0 (oracular) [64-bit]

lsb_release -a:

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 24.10
Release:	24.10
Codename:	oracular

   Compiling nrf9160-rust-starter v0.1.0 (/home/robert/src/rust/nrf91-2.0.1-test)
error[E0432]: unresolved import `nrf_modem::no_std_net`
  --> src/main.rs:10:17
   |
10 | use nrf_modem::{no_std_net::SocketAddr, ConnectionPreference, LteLink, SystemMode, TcpStream};
   |                 ^^^^^^^^^^ could not find `no_std_net` in `nrf_modem`

error[E0425]: cannot find function `application_irq_handler` in crate `nrf_modem`
  --> src/main.rs:33:20
   |
33 |         nrf_modem::application_irq_handler();
   |                    ^^^^^^^^^^^^^^^^^^^^^^^ not found in `nrf_modem`

warning: unused import: `core::str::FromStr`
 --> src/main.rs:5:5
  |
5 | use core::str::FromStr;
  |     ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error: item does not constrain `Fut::{opaque#0}`, but has it in its signature
  --> src/main.rs:16:1
   |
16 | #[embassy_executor::main]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: consider moving the opaque type's declaration and defining uses into a separate module
note: this opaque type is in the signature
  --> src/main.rs:16:1
   |
16 | #[embassy_executor::main]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in the attribute macro `::embassy_executor::task` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0425, E0432.
For more information about an error, try `rustc --explain E0425`.
warning: `nrf9160-rust-starter` (bin "nrf9160-rust-starter") generated 1 warning
error: could not compile `nrf9160-rust-starter` (bin "nrf9160-rust-starter") due to 3 previous errors; 1 warning emitted

diondokter · 2024-12-26T21:36:38Z

Ok, did another fix in this branch. Please update.

It seems you were running on an older version of nrf-modem.
If you go through the readme, you'll see the setup you need to do.

The no_std_net crate is no longer used in favor of the recently stabilized core::net module.
And the application irq doesn't exist anymore, so no need to set that up and call it.

rabarar · 2024-12-26T23:00:13Z

I cloned the main branch to start, and then tested with your fix-transmuted branch - is there a different repo that’s newer?On Dec 26, 2024, at 4:37 PM, Dion Dokter ***@***.***> wrote: Ok, did another fix in this branch. Please update. It seems you were running on an older version of nrf-modem. If you go through the readme, you'll see the setup you need to do. The no_std_net crate is no longer used in favor of the recently stabilized core::net module. And the application irq doesn't exist anymore, so no need to set that up and call it. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

diondokter · 2024-12-26T23:02:15Z

No, I mean your application. You were calling some old APIs that don't exist anymore in the currently released version. That's the source of your errors.

rabarar · 2024-12-26T23:20:50Z

Oh - that was your repo - nrf91-2.0.1-test …On Dec 26, 2024, at 6:02 PM, Dion Dokter ***@***.***> wrote: No, I mean your application. You were calling some old APIs that don't exist anymore in the currently released version. That's the source of your errors. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

diondokter · 2024-12-26T23:23:17Z

Yeah, we talked about that. It was the most up-to-date example I had. But it's not very up-to-date. Your errors are easily fixed if you go through the readme and make sure your code matches what it does

rabarar · 2024-12-27T00:01:33Z

“My” code ;) — got it … I’ll hack at it and submit a PR when I get it working!On Dec 26, 2024, at 6:23 PM, Dion Dokter ***@***.***> wrote: Yeah, we talked about that. It was the most up-to-date example I had. But it's not very up-to-date. Your errors are easily fixed if you go through the readme and make sure your code matches what it does —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

rabarar · 2024-12-27T00:12:07Z

just to be clear, this still needs to use the +nightly, yes?

…

diondokter · 2024-12-27T00:13:37Z

The nrf-modem crate itself can be compiled with stable just fine

rabarar · 2024-12-27T00:59:45Z

okay, I’m down to the following error - and not sure why or how to resolve it. I’m going to fork the nrf91-2.0.1-test code so you can see the main.rs ``` error: item does not constrain `Fut::{opaque#0}`, but has it in its signature --> src/main.rs:20:1 | 20 | #[embassy_executor::main] | ^^^^^^^^^^^^^^^^^^^^^^^^^ in this procedural macro expansion | ::: /home/robert/.cargo/git/checkouts/embassy-c08a80187403f815/4b30394/embassy-macros/src/lib.rs:41:1 | 41 | pub fn task(args: TokenStream, item: TokenStream) -> TokenStream { | ---------------------------------------------------------------- in this expansion of `#[::embassy_executor::task]` | = note: consider moving the opaque type's declaration and defining uses into a separate module note: this opaque type is in the signature --> src/main.rs:20:1 | 20 | #[embassy_executor::main] | ^^^^^^^^^^^^^^^^^^^^^^^^^ error: could not compile `nrf9160-rust-starter` (bin "nrf9160-rust-starter") due to 1 previous error ```

…

On Dec 26, 2024, at 7:13 PM, Dion Dokter ***@***.***> wrote: The nrf-modem crate itself can be compiled with stable just fine — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB2J6D74F6AQ3KTTG34S4L2HSLUNAVCNFSM6AAAAABUHLGSFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTGE4DKNZSGY>. You are receiving this because you were mentioned.

diondokter · 2024-12-27T14:17:07Z

Ok, I updated the nrf91-2.0.1-test repo to the newest nrf-modem version on master

rabarar · 2024-12-27T15:13:24Z

Excellent - thank you very much. I think you need to remove the explicit panic function or it won’t compile - did that and ran it - worked as expected on the nRF9151-DK. In the mean time, I was modifying your code to run in secure mode, and get everything compiled and flashed but get an assertion error on the nrf9120_pac for RAM > 32k the repo is https://github.com/rabarar/nrf91-2.0.1-test I believe I’ve followed the process your required - but perhaps I’ve misread or misunderstood something. Also, I WANT TO THANK YOU for your kind feedback and assistance. Was a bit surprised by the response from the “gentleman” on matrix - not everyone’s willing to be helpful… Best, Rob

…

On Dec 27, 2024, at 9:17 AM, Dion Dokter ***@***.***> wrote: Ok, I updated the nrf91-2.0.1-test repo to the newest nrf-modem version on master — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB2J6H2R4234SIAZ4IICHL2HVOPTAVCNFSM6AAAAABUHLGSFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTG42DINBUGY>. You are receiving this because you were mentioned.

diondokter · 2024-12-27T16:15:17Z

In the mean time, I was modifying your code to run in secure mode, and get everything compiled and flashed but get an assertion error on the nrf9120_pac for RAM > 32k the repo is https://github.com/rabarar/nrf91-2.0.1-test I believe I’ve followed the process your required - but perhaps I’ve misread or misunderstood something.

Not sure about that. There might a difference between the 60/61/51.

Also, I WANT TO THANK YOU for your kind feedback and assistance. Was a bit surprised by the response from the “gentleman” on matrix - not everyone’s willing to be helpful…

No problem, but I do want to stick up for Dario. He's done an incredible amount of work for the community and is generally very helpful. Beyond reasonable even. Not just for embassy, but for the greater embedded Rust ecosystem too.

I'm gonna be blunt and say your question was kinda bad. When you're asking for someone else's time, you should spend time on your question yourself too.

Examples of things you could've done:

Give a link to the code in question so people looking at it don't have to look it up: https://github.com/embassy-rs/embassy/blob/main/embassy-net-nrf91/src/context.rs#L87
When posting a code snippet, post is as code with the triple backticks: ```rust code ```
Show you've looked into it yourself: You just stated in hangs without any other info. You could've asked something like 'wait_init never finishes. It doesn't seem like it, but do I need to do some initialization myself first that I've missed?'.
It shows you're critically thinking about the problem and is a much more specific question. There are so many people who don't do anything themselves and want to depend on others to give all the answers. With your question you looked to be such a person. Those people are not fun to help. You should make other people want to answer your questions.

If you take these tips to heart, I'm sure you'll be more successful in getting your questions answered.

diondokter · 2024-12-27T16:18:51Z

Released 0.6.1 with these changes

rabarar · 2024-12-27T16:32:25Z

points taken - nonetheless, I respectfully disagree. I've certainly not asked anyone to "do my work" as evidenced by the repo I've forked/modified/etc...

having been in the community for over 40 years - I've come to understand some people are more thoughtful/helpful than others. No one owes anyone anything - but assistance especially at the inception of a new ecosystems goes a long way to creating a community of inclusion... just sayin'

and btw - it wasn't my code - it was the code in the example that was in the repo! lol

diondokter added 2 commits December 26, 2024 16:14

Fix transmute for mac?

0579aa5

Run clippy and make rust analyzer happy

12b6a51

Add async dns to CI and do fixes to make it work again

002a440

diondokter merged commit c1193a5 into master Dec 27, 2024
1 check passed

diondokter deleted the fix-transmute branch December 27, 2024 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix transmute #30

Fix transmute #30

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 •

edited

Loading

rabarar commented Dec 26, 2024 via email

rabarar commented Dec 26, 2024

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 via email

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 via email

diondokter commented Dec 26, 2024

rabarar commented Dec 27, 2024 via email

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 •

edited

Loading

Fix transmute #30

Fix transmute #30

Conversation

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 • edited Loading

rabarar commented Dec 26, 2024 via email

rabarar commented Dec 26, 2024

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 via email

diondokter commented Dec 26, 2024

rabarar commented Dec 26, 2024 via email

diondokter commented Dec 26, 2024

rabarar commented Dec 27, 2024 via email

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 via email

diondokter commented Dec 27, 2024

diondokter commented Dec 27, 2024

rabarar commented Dec 27, 2024 • edited Loading

rabarar commented Dec 26, 2024 •

edited

Loading

rabarar commented Dec 27, 2024 •

edited

Loading