Async DNS resolver #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondokter
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Alright, this looks pretty good!
Though I have to say I didn't really review the async dns implementation that thoroughly. I've never implemented DNS before and don't know any of the details.
But since it's behind a feature flag and doesn't use any unsafe, I'm happy enough to merge it.
Did you create the implementation yourself or did you copy somebody else's work?
|
The actual DNS implementation itself is pretty basic but should do in most cases I think. It's all my creation, with a little help by ChatGPT 🙂 |
|
Cool, just making sure we're ok on copyright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.