Remove tool finder #296
Remove tool finder #296
Conversation
| There is a `.node-version` file to simplify setup using [nodenv](https://github.com/nodenv/nodenv). | ||
|
|
||
| ### Dependencies | ||
|
|
||
| Install the dependencies using npm. | ||
|
|
||
| ```bash | ||
| npm install | ||
| npm install --ignore-scripts @strapi/blocks-react-renderer |
There was a problem hiding this comment.
During installation @strapi/blocks-react-renderer runs a husky (some kind of code quality tool) script that fails if you don't have husky installed. With this flag you can skip that part.
|
|
||
| Date: 2024-05-23 | ||
| Date: 2024-05-24 |
There was a problem hiding this comment.
Why did the dates change in some ADRs (not only this one)?
There was a problem hiding this comment.
Ok, hear me out: First, I wanted to consolidate the ADRs by merging them and sorting by date. But then I noticed this led to the wrong order of the ADRs: Decisions that were taken later would come earlier than others. So instead of just reordering the decisions I also changed the date to at least reflect the correct order the decisions were taken in – but didn't spend time on researching the correct date nor doing any other checks like which decisions were actually taken on the same day. As an example, ADR 16 has to come before 17, as 17 discusses GraphQL tooling. It was, however, written a whole month earlier, so I changed the date to make a bit more sense (I noticed this only after your review).
There was a problem hiding this comment.
Ok, I get your intention. Thing is, that the dates in the ADRs do not reflect the date of the decision being taken but the date of the ADR being written. If you now change them, they don't reflect anything. 😄 I don't really care, the exact date does not really matter. Maybe we can to use the date of the decision being taken in the future. So whenever we take a decision, we either create a ticket to write the ADR and write down the date or we create an empty ADR file with a date and the rest ist TDB.
There was a problem hiding this comment.
Totally d'accord with creating a stub each time we take a decision, let's do that!
Remove strategy and shouldRunIntegrationTests
|
No description provided.