Parameterize submission config

digitalservicebund · Sep 24, 2024 · 483afe5 · 483afe5
1 parent 4b939a7
commit 483afe5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/main/java/de/bund/digitalservice/a2j/service/FitConnectSenderService.java b/src/main/java/de/bund/digitalservice/a2j/service/FitConnectSenderService.java
@@ -11,12 +11,22 @@
 import dev.fitko.fitconnect.client.bootstrap.ClientFactory;
 import java.net.URI;
 import java.util.UUID;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Service;
 
 @Service
 public class FitConnectSenderService implements SenderService {
   private final SenderClient client;
 
+  @Value("${submission.destination}")
+  private String destinationUuid;
+  @Value("${submission.serviceType.urn}")
+  private String serviceUrn;
+  @Value("${submission.serviceType.name}")
+  private String serviceName;
+  @Value("${submission.jsonUri}")
+  private String jsonUri;
+
   public FitConnectSenderService(ApplicationConfig config) {
     this.client = ClientFactory.createSenderClient(config);
   }
@@ -25,9 +35,9 @@ public FitConnectSenderService(ApplicationConfig config) {
   public String submit(SubmitRequest submitRequest) {
     SendableSubmission submission =
         SendableSubmission.Builder()
-            .setDestination(UUID.fromString("89126fd7-1069-46f1-9cdc-152037db95a9"))
-            .setServiceType("urn:de:fim:leika:leistung:99400048079000", "Simple Dummy Service")
-            .setJsonData(buildJSON(submitRequest.message()), URI.create("urn:data"))
+            .setDestination(UUID.fromString(destinationUuid))
+            .setServiceType(serviceUrn, serviceName)
+            .setJsonData(buildJSON(submitRequest.message()), URI.create(jsonUri))
             .build();
 
     try {

diff --git a/src/main/resources/application.yaml b/src/main/resources/application.yaml
@@ -0,0 +1,6 @@
+submission:
+  destination: 89126fd7-1069-46f1-9cdc-152037db95a9
+  serviceType:
+    urn: urn:de:fim:leika:leistung:99400048079000
+    name: Simple Dummy Service
+  jsonUri: urn:data