Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Storybook optimize deps console errors #3308

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Mar 5, 2025

Fixes [vite] (client) Pre-transform error: The file does not exist at…

Storybook uses vite config in relative to where storybook runs from

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Preview deployments for this pull request:

No deployments found.

@@ -25,9 +25,6 @@ export default defineConfig({
},
// Temporary "fix" https://github.com/storybookjs/storybook/issues/28542
optimizeDeps: {
exclude: [
'./apps/storybook/node_modules/.cache/storybook',
'./apps/storybook/docs-components',
Copy link
Collaborator Author

@mimarz mimarz Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was docs-components previously excluded?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was here to fix an issue where storybook would crash when importing these components.
Seems like this has been fixed, since the issue is no long occuring.

@mimarz mimarz marked this pull request as ready for review March 5, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants