Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix misc layout things #3294

Merged
merged 10 commits into from
Mar 4, 2025
Merged

chore: fix misc layout things #3294

merged 10 commits into from
Mar 4, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Mar 4, 2025 •
edited
Loading

related to #3232
resolves #3234

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2778e30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

Preview deployments for this pull request:

Storefront - 4. Mar 2025 - 14:11

Theme - 4. Mar 2025 - 14:10

@Barsnes Barsnes changed the title chore(storefront): fix misc layout things chore: fix misc layout things Mar 4, 2025
@Barsnes Barsnes marked this pull request as ready for review March 4, 2025 08:32
@Barsnes Barsnes marked this pull request as draft March 4, 2025 09:31
@Barsnes Barsnes marked this pull request as ready for review March 4, 2025 11:42
@Barsnes Barsnes merged commit ca45433 into next Mar 4, 2025
5 checks passed
@Barsnes Barsnes deleted the post-v1/misc-fixes branch March 4, 2025 14:26
@Barsnes Barsnes mentioned this pull request Mar 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@oddvernes oddvernes Awaiting requested review from oddvernes oddvernes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded codesandbox have a keyboard trap
2 participants
@Barsnes @mimarz