Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Chip): max height and width fit-content #3277

Merged
merged 1 commit into from
Mar 3, 2025
Merged

style(Chip): max height and width fit-content #3277

merged 1 commit into from
Mar 3, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Mar 3, 2025

No description provided.

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: f15d338

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Preview deployments for this pull request:

Storybook - 3. Mar 2025 - 08:27

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.96% 3209 / 6690
🔵 Statements 47.96% 3209 / 6690
🔵 Functions 84.55% 219 / 259
🔵 Branches 77.51% 562 / 725
File CoverageNo changed files found.
Generated in workflow #2329 for commit f15d338 by the Vitest Coverage Report Action

@Barsnes Barsnes marked this pull request as ready for review March 3, 2025 07:27
Copy link
Contributor

@eirikbacker eirikbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
should we have min-width: 0 as well to prevent shrinking in flex-containers? 🤔

@mimarz
Copy link
Collaborator

mimarz commented Mar 3, 2025

👍 should we have min-width: 0 as well to prevent shrinking in flex-containers? 🤔

Good question. Made an issue for this in general #3279

@mimarz mimarz merged commit 107162f into next Mar 3, 2025
10 of 12 checks passed
@Barsnes Barsnes deleted the chip/sizing branch March 3, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants