Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): correct font-weight, font-family tokens and values #3264

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Feb 28, 2025

  • Fix incorrect values for font-weight according to Token Studio (for syncing to Figma variables)
  • Conform tokens for font-weight, font-family
  • Fix incorrect values for secondary typography set

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 17806ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 28, 2025

Preview deployments for this pull request:

Storybook - 3. Mar 2025 - 09:51

Storefront - 3. Mar 2025 - 09:51

Copy link
Contributor

github-actions bot commented Feb 28, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.96% 3209 / 6690
🔵 Statements 47.96% 3209 / 6690
🔵 Functions 84.55% 219 / 259
🔵 Branches 77.51% 562 / 725
File CoverageNo changed files found.
Generated in workflow #2345 for commit 17806ac by the Vitest Coverage Report Action

…ken names (#3268)

* Fixed weird token names

* fix(cli): update cli to new token structure after fixing incorrect token names

* back to just font-family

* font-family.main -> font-family

* font-family.main -> font-family

* update template

* built new tokens

---------

Co-authored-by: Lasse Febakke Straum <33222679+Febakke@users.noreply.github.com>
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@mimarz mimarz changed the title fix(cli): fix extra-bold font weight value fix(cli): Correct font-weight tokens and values Mar 3, 2025
@mimarz mimarz changed the title fix(cli): Correct font-weight tokens and values fix(cli): correct font-weight, font-family tokens and values Mar 3, 2025
@mimarz mimarz requested a review from unekinn March 3, 2025 08:59
@mimarz mimarz merged commit 2012614 into next Mar 3, 2025
10 of 12 checks passed
@mimarz mimarz deleted the fix-cli-typography-type branch March 3, 2025 09:06
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants