Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customizing sizes #3248

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

Conversation

unekinn
Copy link
Contributor

@unekinn unekinn commented Feb 27, 2025

DO NOT MERGE - test-custom-sizes.d.ts just exists to prove it works


This PR shows an approach we could use if we wanted to allow consumers to define their own sizing scale

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: fa2f901

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Preview deployments for this pull request:

Storybook - 3. Mar 2025 - 14:19

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.95% 3210 / 6694
🔵 Statements 47.95% 3210 / 6694
🔵 Functions 84.61% 220 / 260
🔵 Branches 77.44% 563 / 727
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/sizes.ts 0% 0% 0% 0%
packages/react/src/types.ts 0% 0% 0% 0%
packages/react/src/components/Avatar/Avatar.tsx 75% 100% 50% 75% 89-99
packages/react/src/components/Combobox/useFormField/useFormField.ts 100% 71.42% 100% 100%
packages/react/src/components/Heading/Heading.tsx 100% 50% 100% 100%
packages/react/src/components/Paragraph/Paragraph.tsx 100% 100% 100% 100%
packages/react/src/components/Spinner/Spinner.tsx 100% 100% 100% 100%
Generated in workflow #2360 for commit fa2f901 by the Vitest Coverage Report Action

@mimarz mimarz added the post-v1 temporary label for issues/pr after v1 release label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-v1 temporary label for issues/pr after v1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants