Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove use of combobox #3238

Merged
merged 5 commits into from
Feb 27, 2025
Merged

docs: remove use of combobox #3238

merged 5 commits into from
Feb 27, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Feb 27, 2025

In this PR, it is also on dialog stories. This is removed in #3210

Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 9034adb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review February 27, 2025 07:56
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Preview deployments for this pull request:

Storybook - 27. Feb 2025 - 13:55

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.36% 3209 / 6372
🔵 Statements 50.36% 3209 / 6372
🔵 Functions 85.31% 215 / 252
🔵 Branches 77.71% 558 / 718
File CoverageNo changed files found.
Generated in workflow #2283 for commit 9034adb by the Vitest Coverage Report Action

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an issue so we remember to have a look at the a11y rules we have disabled. #3245

Feel free to update the issue with missing information :)

@mimarz mimarz merged commit 111f715 into next Feb 27, 2025
8 of 10 checks passed
@mimarz mimarz deleted the storybook/combobox branch February 27, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants