feat: remove severity colors from default 'data-color' type #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16fc286 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
unekinn
force-pushed
the
split-severity-from-color-type
branch
from
01f90fd to
aa15a92
Compare
unekinn
requested review from
mimarz,
Barsnes,
eirikbacker and
oddvernes
as code owners
mimarz
approved these changes
Feb 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeverityColorsfromColortype, and addsSeverityColorsexplicitly todata-coloron the components where we deem severity to be relevant.Buttoncomponent only getsdangerfrom severity.{}fallback fromColorWithFallbackwhenMainAndSupportColorsis not extended.string | undefined, and notstring | {} | "info" | "success" | "warning" | "danger", as the latter would give autocomplete that suggests only the severity colors are valid choicesMainAndSupportColorsis extended with e.g. "accent" and "extra" colors, the type will resolve to"neutral" | "accent" | "info" | "success" | "warning" | "danger"and autocomplete will workFixes #3183