Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better proptype generator #2423

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix: better proptype generator #2423

merged 4 commits into from
Sep 16, 2024

Conversation

eirikbacker
Copy link
Contributor

Adjusted after fabulous feedback from @unekinn 🙌 🫶

@eirikbacker eirikbacker self-assigned this Sep 16, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 511f205

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 16. Sep 2024 - 14:51 (Norwegian time)

@eirikbacker eirikbacker marked this pull request as draft September 16, 2024 12:42
@eirikbacker eirikbacker marked this pull request as ready for review September 16, 2024 12:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.78% 4600 / 7212
🔵 Statements 63.78% 4600 / 7212
🔵 Functions 86.26% 157 / 182
🔵 Branches 75.76% 591 / 780
File CoverageNo changed files found.
Generated in workflow #337

unekinn
unekinn approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@unekinn unekinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

mimarz
mimarz approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if @unekinn approves, I approve 🥁

@mimarz
Copy link
Collaborator

mimarz commented Sep 16, 2024

Does this mean we can enable react-docgen-typescript locally? 😋

@eirikbacker eirikbacker merged commit ec741bc into next Sep 16, 2024
4 checks passed
@eirikbacker eirikbacker deleted the fix/proptype-type-gen branch September 16, 2024 13:17
mimarz pushed a commit that referenced this pull request Feb 21, 2025
@eirikbacker @mimarz
fix: better proptype generator (#2423)
34c8939 
Adjusted after fabulous feedback from @unekinn 🙌 🫶
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unekinn unekinn unekinn approved these changes

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Barsnes approved these changes

Assignees

@eirikbacker eirikbacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikbacker @mimarz @unekinn @Barsnes