Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: only run theme preview on changes in theme folder #2417

Merged
merged 6 commits into from
Sep 16, 2024
Merged

chore: only run theme preview on changes in theme folder #2417

merged 6 commits into from
Sep 16, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Sep 16, 2024 •
edited
Loading

only deploy theme when there are changes in that folder, also tries to append the preview to the preview comment.
Removes https://dev.designsystemet.no from preview comment

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a657e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Preview deployments for this pull request:

No deployments found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 63.75% 4590 / 7200
🔵 Statements 63.75% 4590 / 7200
🔵 Functions 86.11% 155 / 180
🔵 Branches 75.8% 586 / 773
File CoverageNo changed files found.
Generated in workflow #310

@Barsnes Barsnes marked this pull request as ready for review September 16, 2024 07:57
@Barsnes Barsnes mentioned this pull request Sep 16, 2024
Merged
@Barsnes Barsnes merged commit c2f0f07 into next Sep 16, 2024
3 checks passed
@Barsnes Barsnes deleted the workflow/theme branch September 16, 2024 09:53
mimarz pushed a commit that referenced this pull request Feb 21, 2025
@Barsnes @mimarz
chore: only run theme preview on changes in theme folder (#2417)
519270f 
only deploy theme when there are changes in that folder, also tries to
append the preview to the preview comment.
Removes https://dev.designsystemet.no from preview comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz