Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(SkipLink): restyle skiplink to look like link #2260

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Aug 15, 2024

resolves #2140

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: ab77c22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@digdir/designsystemet-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review August 15, 2024 09:38
Copy link
Contributor

github-actions bot commented Aug 15, 2024

Preview deployments for this pull request:

📖 Storybook 15. Aug 2024 - 12:21 (Norwegian time)

See all deployments at https://dev.designsystemet.no

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Added a changeset as this changes styling, again, but now its documented to the final iteration hopefully! 🤪

@Barsnes
Copy link
Member Author

Barsnes commented Aug 15, 2024

LGTM 👍

Added a changeset as this changes styling, again, but now its documented to the final iteration hopefully! 🤪

Yes we have changed this quite a bit, and it is now quite a bit different from the prod version.
Was unsure if I should add a changeset, since I believe we have omitted style: PR before.

@Barsnes Barsnes merged commit 1d79992 into next Aug 15, 2024
4 checks passed
@Barsnes Barsnes deleted the style/skiplink branch August 15, 2024 11:22
Barsnes pushed a commit that referenced this pull request Aug 21, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@0.1.0-next.23

### Minor Changes

- Update init script to new design-tokens format
([#2255](#2255))

## @digdir/designsystemet-css@0.11.0-next.12

### Minor Changes

- SkipLink: New style
([#2260](#2260))

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Table: Width is now by default `100%`
([#2285](#2285))

- AccordionHeading: Correct name on types
([#2276](#2276))

## @digdir/designsystemet-react@1.0.0-next.17

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Combobox: Make controlled input adhere to `inputValue` and send all
change events
([#2267](#2267))

- AccordionHeading: Correct name on types
([#2276](#2276))

- Badge: Export component
([#2297](#2297))

- ToggleGroup, Tabs: Active item equality check is now strict
([#2253](#2253))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mimarz added a commit that referenced this pull request Feb 21, 2025
resolves #2140

---------

Co-authored-by: Michael Marszalek <mimarz@gmail.com>
mimarz pushed a commit that referenced this pull request Feb 21, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@0.1.0-next.23

### Minor Changes

- Update init script to new design-tokens format
([#2255](#2255))

## @digdir/designsystemet-css@0.11.0-next.12

### Minor Changes

- SkipLink: New style
([#2260](#2260))

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Table: Width is now by default `100%`
([#2285](#2285))

- AccordionHeading: Correct name on types
([#2276](#2276))

## @digdir/designsystemet-react@1.0.0-next.17

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Combobox: Make controlled input adhere to `inputValue` and send all
change events
([#2267](#2267))

- AccordionHeading: Correct name on types
([#2276](#2276))

- Badge: Export component
([#2297](#2297))

- ToggleGroup, Tabs: Active item equality check is now strict
([#2253](#2253))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forslag til detaljering av Skip Link
2 participants