Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace forEach with for..of #2251

Merged
merged 3 commits into from
Aug 14, 2024
Merged

chore: replace forEach with for..of #2251

merged 3 commits into from
Aug 14, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Aug 14, 2024

resolves #2247

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 249588b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 14. Aug 2024 - 13:49 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review August 14, 2024 11:43
mimarz
mimarz reviewed Aug 14, 2024
View reviewed changes
mimarz
mimarz approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look to work just fine as before :)

@Barsnes Barsnes merged commit fe8f9de into next Aug 14, 2024
4 checks passed
@Barsnes Barsnes deleted the biome/no-for-each branch August 14, 2024 11:50
mimarz pushed a commit that referenced this pull request Feb 21, 2025
@Barsnes @mimarz
chore: replace forEach with for..of (#2251)
cefa688 
resolves #2247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable noForEach rule
2 participants
@Barsnes @mimarz