Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Accordion): fix defaultOpen flicker on first render #2214

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Aug 8, 2024

resolves #2178

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 8d593db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Preview deployments for this pull request:

📖 Storybook 8. Aug 2024 - 09:03 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review August 8, 2024 07:24
@Barsnes Barsnes requested a review from mimarz as a code owner August 8, 2024 07:24
@Barsnes Barsnes merged commit 90ca009 into next Aug 12, 2024
4 checks passed
@Barsnes Barsnes deleted the chore/accordion_default-open branch August 13, 2024 10:45
mimarz pushed a commit that referenced this pull request Aug 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@0.1.0-next.22

### Minor Changes

- feat: Convert to W3C design token format
([#2240](#2240))

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

- fix: Export correct types for color
([`e6325afa14e349698daf1082ba8844e80f46c5c0`](e6325af))

## @digdir/designsystemet-react@1.0.0-next.16

### Minor Changes

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

### Patch Changes

- Modal: add missing ModalRoot export
([#2228](#2228))

- RovingFocus: add `orientation` to support for different arrow
directions, and add support home/end buttons
([#2206](#2206))

    -   Affects `ToggleGroup`, where up and down arrows can now be used
    -   Affects `ToggleGroup`, where home and end can now be used
    -   Affects `Tabs`, where home and end can now be used

- Accordion: Fix `defaultOpen` flicker on first render
([#2214](#2214))

- Tabs: Make arrow keys work in any direction
([#2223](#2223))

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Divider: hide from screen readers
([#2232](#2232))

- Modal: remove `FloatingFocusManager`
([#2224](#2224))

- NativeSelect: add focus in `readOnly` state
([#2212](#2212))

## @digdir/designsystemet-css@0.11.0-next.11

### Patch Changes

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Button: `text-align: inherit` when not in full width
([#2216](#2216))

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

## @digdir/designsystemet-theme@1.0.0-next.15

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mimarz pushed a commit that referenced this pull request Feb 21, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/designsystemet@0.1.0-next.22

### Minor Changes

- feat: Convert to W3C design token format
([#2240](#2240))

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

- fix: Export correct types for color
([`e6325afa14e349698daf1082ba8844e80f46c5c0`](e6325af))

## @digdir/designsystemet-react@1.0.0-next.16

### Minor Changes

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

### Patch Changes

- Modal: add missing ModalRoot export
([#2228](#2228))

- RovingFocus: add `orientation` to support for different arrow
directions, and add support home/end buttons
([#2206](#2206))

    -   Affects `ToggleGroup`, where up and down arrows can now be used
    -   Affects `ToggleGroup`, where home and end can now be used
    -   Affects `Tabs`, where home and end can now be used

- Accordion: Fix `defaultOpen` flicker on first render
([#2214](#2214))

- Tabs: Make arrow keys work in any direction
([#2223](#2223))

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Divider: hide from screen readers
([#2232](#2232))

- Modal: remove `FloatingFocusManager`
([#2224](#2224))

- NativeSelect: add focus in `readOnly` state
([#2212](#2212))

## @digdir/designsystemet-css@0.11.0-next.11

### Patch Changes

- Fixes so spacing is the same in checkbox and radio groups
([#2234](#2234))

- Button: `text-align: inherit` when not in full width
([#2216](#2216))

- Breadcrumbs: ✨ new component
([#2226](#2226))

- Badge: ✨ New component
([#2220](#2220))

## @digdir/designsystemet-theme@1.0.0-next.15

### Patch Changes

- refactor: single CSS file for theme
([#2204](#2204))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccordionItem with defaultOpen set to true initially shows as closed, but with contents overflowing
2 participants