-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storefront): Migrate page to new routing #2158
Conversation
995f006
to
60db4d5
Compare
60db4d5
to
619d0e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! ❤️
I looks like you forgot to rename the pages under grunnleggende
The GitHubLink.tsx
link also seems to be throwing an error, but the path here would also need to be updated to route/page.mdx
We also need to add meta data, so we get titles for the pages.
This was previously done with a <Meta />
component, but in the app router we need to export it:
export const metadata = {
title: '...',
description: '...',
};
I'd like to move over to layout.tsx
files as well, but it works now and can always be done later on. We also have the issue of props that layouts need 🤔
Otherwise everything looks great 🎯
Migrate all pages to app router Migrate some components to new routing structure Migrated all metadata to new export Removed old Meta component
619d0e6
to
6c96429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barsnes I had some trouble with the sizes. Tried to match it to the latest build off i think it was the react package. Tried to keep it in sync. |
You might not have built it locally? We are using the workspace package, and not from npm. |
resolves #1748 Migrate all pages to app/ routing Migrate some components to new routing structure
Fix for #1748
Migrate all pages to app/ routing
Migrate some components to new routing structure