Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): 🎨 apps/theme enabled in all linters #2101

Closed
wants to merge 1 commit into from

Conversation

poi33
Copy link
Collaborator

@poi33 poi33 commented Jun 4, 2024

Fix for #2005

Included apps/theme in tsconfig root
Extended apps/theme tsconfig to include the root tsconfig
Fixed eslint errors/warnings
No longer ignore apps/theme in stylelintignore
Fixed stylelint errors

@poi33 poi33 requested review from mimarz and Barsnes as code owners June 4, 2024 16:19
@mimarz mimarz changed the base branch from main to next June 5, 2024 09:39
@mimarz
Copy link
Collaborator

mimarz commented Jun 5, 2024

Sorry, we didn't flag the issue correctly but we have done a lot of these changes and other for the upcoming release of V1. We've been in crunch for quite some time so not all is updated yet everywhere.

All the changes that have been done that regards is in the next branch. I changed the target for you on this PR to check how many conflict would occur.

Apologise for the wasted work 🙈 Either way, thanks for the effort! 👏

@poi33
Copy link
Collaborator Author

poi33 commented Jun 5, 2024

@mimarz thats okay. I will like to see what i did is even close to the next branch.

@mimarz
Copy link
Collaborator

mimarz commented Jun 5, 2024

@mimarz thats okay. I will like to see what i did is even close to the next branch.

Alrighty. We haven't sorted out all our environments yet. Going forward next will be the development branch and main be whats currently published to production/(@latest). Plan is to also introduce more automated CI, so whats on next will automatically be published to for example next.storybook.designsystemet.no and @digdir/designsystemet-react@next

@mimarz
Copy link
Collaborator

mimarz commented Jun 12, 2024

Can we close this or did you want to look at it more? @poi33 ?

@poi33
Copy link
Collaborator Author

poi33 commented Jun 12, 2024

Yeah, I'll close it. Its not going to contribute much

@poi33 poi33 closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants