Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Button): Removed inverted color #1828

Merged
merged 5 commits into from
Apr 15, 2024
Merged

feat(Button): Removed inverted color #1828

merged 5 commits into from
Apr 15, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Apr 15, 2024 •
edited
Loading

BREAKING CHANGE: Removed inverted color
Resolves #1826

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 15. Apr 2024 - 12:00 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review April 15, 2024 09:55
@Barsnes Barsnes requested a review from mimarz as a code owner April 15, 2024 09:55
@Barsnes Barsnes changed the title chore(Button): Remove use of inverted chore(Button): Remove inverted Apr 15, 2024
mimarz
mimarz requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm, this needs to be changed to feat: and add "BREAKING CHANGE: Removed inverted color" as its a breaking change

@Barsnes Barsnes changed the title chore(Button): Remove inverted feat(Button): Remove inverted Apr 15, 2024
@mimarz mimarz changed the title feat(Button): Remove inverted feat(Button): Removed inverted color Apr 15, 2024
mimarz
mimarz approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit 01ad9c5 into main Apr 15, 2024
9 checks passed
@Barsnes Barsnes deleted the button/-no-inverted branch April 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove inverted use in Button
2 participants
@Barsnes @mimarz