Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Popover): Update docs #1440

Merged
merged 7 commits into from
Feb 2, 2024
Merged

docs(Popover): Update docs #1440

merged 7 commits into from
Feb 2, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 30, 2024 •
edited
Loading

Resolves #1436
Resolves #1002

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 2. Feb 2024 - 09:42 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes marked this pull request as ready for review January 30, 2024 11:49
@Barsnes Barsnes requested a review from mimarz as a code owner January 30, 2024 11:49
mimarz
mimarz requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest doing the same changes to structure and wording as in #1416

@Barsnes Barsnes requested a review from mimarz February 1, 2024 07:29
@Barsnes @mimarz
Update packages/react/src/components/Popover/Popover.mdx
818f8f8 
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
mimarz
mimarz approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit 9670654 into main Feb 2, 2024
3 checks passed
@Barsnes Barsnes deleted the docs/popover branch February 2, 2024 13:41
Barsnes added a commit that referenced this pull request Feb 6, 2024
@Barsnes @mimarz
docs(Popover): Update docs (#1440)
922925d 
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Popover documentation Update interactive popover example
2 participants
@Barsnes @mimarz