-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AGP 8 #1
Update AGP 8 #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 Here are Code Reviews by SenpAI:
object Cart : Screen("cart") | ||
object Profile : Screen("profile") | ||
object DetailReward : Screen("home/{rewardId}") { | ||
data object Home : Screen("home") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Penggunaan data object
lebih tepat untuk merepresentasikan screen yang tidak memiliki state. Pertimbangkan untuk konsisten menggunakan data object
pada semua screen jika tidak ada properti tambahan selain route
.
} | ||
} | ||
compileOptions { | ||
sourceCompatibility = JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sejak Java 9, versi 1.8 sudah dianggap usang. Pertimbangkan untuk memperbarui sourceCompatibility
dan targetCompatibility
ke versi yang lebih baru (misalnya, VERSION_17) untuk memanfaatkan fitur-fitur bahasa dan peningkatan kinerja yang lebih baru.
targetCompatibility = JavaVersion.VERSION_1_8 | ||
} | ||
kotlinOptions { | ||
jvmTarget = "1.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sejalan dengan sourceCompatibility
dan targetCompatibility
, pertimbangkan untuk memperbarui jvmTarget
ke versi yang lebih baru (misalnya, 17) agar sesuai dengan fitur-fitur bahasa yang digunakan.
import androidx.compose.foundation.layout.Arrangement | ||
import androidx.compose.foundation.layout.Row | ||
import androidx.compose.foundation.layout.padding | ||
import androidx.compose.foundation.layout.size | ||
import androidx.compose.foundation.shape.RoundedCornerShape | ||
import androidx.compose.material3.MaterialTheme | ||
import androidx.compose.material3.Surface | ||
import androidx.compose.material3.OutlinedIconButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Penggunaan OutlinedIconButton
lebih sesuai untuk memberikan indikasi visual yang jelas bahwa ini adalah tombol yang dapat ditekan. Pastikan ikon yang digunakan di dalamnya mudah dikenali dan sesuai dengan fungsinya.
testing-pada-compose/MyComposeTesting/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
@@ -1,8 +1,14 @@ | |||
pluginManagement { | |||
repositories { | |||
gradlePluginPortal() | |||
google() | |||
google { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Konfigurasi content
pada repositori Google dapat membatasi dependensi yang dapat diunduh. Pastikan konfigurasi ini sesuai dengan kebutuhan proyek dan tidak menghalangi dependensi yang diperlukan. Periksa kembali daftar includeGroupByRegex
untuk memastikan semua grup ID yang diperlukan tercakup.
No description provided.