Remove ObstacleMapGenerator #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObstacleMapGenerator was a copy of the TraversabilityMapGenerator. It only added the check whether the robot box collided with the surrounding MLS above the stepheight. Basically, it checked for collision with overhanging MLS patches based on the robot dimensions. I have moved the collision check to the TraversabilityGenerator3d.
The use of both ObstacleMapGenerator and TraversabilityGenerator3d meant that we had doubled function calls e.g. expandMap.. inflateObstacles.. etc.