Fix: Check for all of vizkit3d, vizkit3d_debug_drawings libraries #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug drawings are marked optional, so we must check for all of them, vizkit3d-qt5 and vizkit3d(qt4 version) can be absent depending on the version of vizkit3d being compiled or settings in vizkit3d, independent of the presence of Qt4 or Qt5.
|
This is @Priyanka328 PR(#20), fixed(need to use _FOUND variables) and expanded somewhat. @haider8645 @chhtz Please take a look if this works for you. |
|
it works. but looks like CI fails due to rock package. |
chhtz
approved these changes
Nov 18, 2024
|
I should have tested on a fresh checkout before merging. |
Ah, sorry about that, should have looked more closely what i was shuffling about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug drawings are marked optional, so we must check for all of them, vizkit3d-qt5 and vizkit3d(qt4 version) can be absent depending on the version of vizkit3d being compiled or settings in vizkit3d, independent of the presence of Qt4 or Qt5.