Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #18

Merged
merged 19 commits into from
Nov 19, 2024
Merged

Add unit tests #18

merged 19 commits into from
Nov 19, 2024

Conversation

haider8645
Copy link
Collaborator

@haider8645 haider8645 commented Nov 13, 2024

Added unit tests for core classes. The unit tests for now are just the start and will add more over time.

  • Update readme

@haider8645 haider8645 mentioned this pull request Nov 13, 2024
@soraxas
Copy link
Contributor

soraxas commented Nov 13, 2024

Why is there no assertion on the generated motion in terms of their coordinate/PoseWithCell/spline etc.? (to ensure the behaviour doesn't change over new commits).

Same goes for some other similar tests.
When there's no assertion inside the test case it only checks that it doesn't "crash" but not assurance of consistent behaviour.

@haider8645
Copy link
Collaborator Author

haider8645 commented Nov 14, 2024

I have added tests for the various types of motions, their associated splines / poses, and the computation of costs. Each motion type from Forward, Backward, Point-turn and Lateral has unique aspects which are individually tested.

Added also tests which check the validity of underlying values of position and orientation splines in the planner generated trajectories etc.

@soraxas
Copy link
Contributor

soraxas commented Nov 19, 2024

The changes looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants