Fixes to SMURFA io and conversion #373
Conversation
…her func Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
…te of self.model Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
…n given a dict with x,y,z keys and values Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
|
@hwiedPro @AlpenAalAlex I have created a draft pull request. Please have a look if u like. |
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
This function does not properly assemble a consistent URDF/SMURF from an Arrangement! Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
…or proper export Also, interface renaming has to be done according to root_entity only This runs through but my example produces a weird URDF (which makes MARS crash) Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
…ctory conversion (which is a SMURFA to SMURF conversion actually) Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
|
@hwiedPro @AlpenAalAlex so far the smurfa generation and conversion to smurf works pipeline wise. However the transformations i produce or which are produced seem to be broken somehow. I also have Entities in there which get modified by exchange_root(). In what state are Arrangement::assemble() and Robot::exchange_root()? Are these well-tested or have to be treated as being experimental? |
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
To be tested Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
|
Status update: Robot::exchange_root() was not producing correct results. |
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
…nsformed Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
|
Thank you so much. I will take a look |
Experimental I assume |
Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
phobos/scripts/convert.py
Outdated
| robot = world.assemble() | ||
| else: | ||
| robot = Robot(inputfile=args.input) | ||
|
|
||
| # Check results | ||
| if not world and not not robot: |
There was a problem hiding this comment.
Is "not not" intended? I think for robots multiple.py:201 has to be
anchor=anchor,
world=self
There was a problem hiding this comment.
Was not intended. Fixed it.
There was a problem hiding this comment.
Is "not not" intended? I think for robots multiple.py:201 has to be
anchor=anchor, world=self
I don't know if that is correct. Haven't touched this.
Description
The complete IO handling and processing of Arrangements is currently not working correctly.
A SMURFA needs to also export its entities to be reimportable and therefore processable by e.g.
phobos/scripts/convert.pyRelated Issue
#367
Motivation and Context
I am currently working on creating a SMURFA from a database backend.
Because the SMURFA handling is not working, the inner parts and assemblies are not correctly converted to a top-level model (aka SMURF)
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: