Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

결과 페이지 피드백 없을 때, 공유 버튼 로직 #496

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

hyesungoh
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

  • 공유 버튼 로직을 더해요

🎉 변경 사항

  • 기존 라우트를 다르게 판단하는 구조에서

    • 한 페이지안에서 응답 값을 기준으로 렌더링하는 컴포넌트를 나누었어요
    • 서비스 흐름상 파악하기 더 쉬운 방법일 것이라 판단했읍니다
  • BottomBar 컴포넌트가 높이가 있는 div(remainer)를 같이 둡니다요

  • 몇가지 스타일 및 린트

@hyesungoh hyesungoh self-assigned this Mar 23, 2024
Copy link

Bundle Sizes

Compared against 57ce4fa

Route Size (gzipped) Diff
/result 120.65 KB +4.86 KB
/survey/base 88.4 KB +4.8 KB
/survey/create 103.94 KB -4.5 KB

Dynamic import: No significant changes found

@github-actions github-actions bot added the test: unit Generate or update unit test label Mar 26, 2024
@hyesungoh hyesungoh merged commit 13c0a9e into main Mar 26, 2024
13 checks passed
@hyesungoh hyesungoh deleted the feature/survey-empty-logic branch March 26, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: unit Generate or update unit test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant