Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 인증 정보로 회원 조회 로직 개발 #28

Merged
merged 19 commits into from
Feb 20, 2025
Merged

Conversation

CEO-Nick
Copy link
Member

@CEO-Nick CEO-Nick commented Feb 18, 2025

#22

Proposed Changes

  • OAuth 인증 정보(subject, provider)를 기반으로 특정 회원(Member)을 조회

  • QueryDSL을 활용해 oauthProvidersubject를 기준으로 회원을 조회하는 함수 정의

  • 메서드 반환 타입은 Member? -> 추후 서비스 계층에서 자동 회원가입하기 위해서(null인 경우 Member 객체 생성해 저장)

Code Review Point

  • 테스트 코드 잘 작성했는지
  • QueryDSL 라이브러리 세팅 잘 되었는지
  • QueryDSL 코드 잘 작성되었는지

@CEO-Nick CEO-Nick added the Feature 기능 개발 label Feb 18, 2025
@CEO-Nick CEO-Nick added this to the 1차 MVP 개발 milestone Feb 18, 2025
@CEO-Nick CEO-Nick self-assigned this Feb 18, 2025
Copy link
Collaborator

@keongmini keongmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@skydreamer21 skydreamer21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 👍

@CEO-Nick CEO-Nick merged commit 925cb2f into develop Feb 20, 2025
3 checks passed
@CEO-Nick CEO-Nick deleted the feat/22 branch February 20, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants