Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM Smoke Tests After get-intrinsic Dependency Update #267

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Feb 25, 2025

This PR updates the NPM smoke tests to reflect the recent update of the get-intrinsic package from version 1.2.7 to 1.3.0. The dependency changes affected the expected test output, requiring adjustments to maintain test accuracy. No functional changes were made—only test updates to align with the new dependency structure.

@kbukum1 kbukum1 requested a review from a team as a code owner February 25, 2025 02:47
abdulapopoola
abdulapopoola previously approved these changes Feb 25, 2025
abdulapopoola
abdulapopoola previously approved these changes Feb 25, 2025
honeyankit
honeyankit previously approved these changes Feb 25, 2025
@kbukum1 kbukum1 closed this Feb 25, 2025
@kbukum1 kbukum1 reopened this Feb 25, 2025
@kbukum1 kbukum1 dismissed stale reviews from honeyankit and abdulapopoola via 141801f February 25, 2025 17:14
@kbukum1 kbukum1 force-pushed the kamil/fix-npm-smoke-test branch from 696bd1b to 141801f Compare February 25, 2025 17:14
Copy link
Contributor

@robaiken robaiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@kbukum1 kbukum1 merged commit f13d71e into main Feb 25, 2025
77 of 79 checks passed
@kbukum1 kbukum1 deleted the kamil/fix-npm-smoke-test branch February 25, 2025 17:17
@kbukum1
Copy link
Contributor Author

kbukum1 commented Feb 25, 2025

Thanks for fixing this!

Thanks for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants