Remove two more hardcoded master references
#7131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
remove-remaining-hardcoded-master-references
branch
2 times, most recently
from
59f8f58 to
f632c3c
Compare
jeffwidman
changed the title
master referencesmaster references
|
And two code failures... since these are two separate ecosystems, I'll likely break this into two separate PR's... I suspect this indicates we'll need to still hardcode some value, but perhaps we can get away with |
abdulapopoola
approved these changes
Apr 24, 2023
abdulapopoola
approved these changes
Mar 7, 2024
Removing two more hardcoded references to `master` that I discovered. Originally I assumed we'd need to flip these to `HEAD`, but in `https://github.com/dependabot/dependabot-core/pull/6149` we were able to get away with simply removing the hardcoded reference altogether in the `bundler` ecosystem and we haven't seen any ill effects the past 6 months... So let's try removing this and see if it works as smoothly in these ecosystems as it did in the `bundler` ecosystem.
jeffwidman
force-pushed
the
remove-remaining-hardcoded-master-references
branch
from
1b4dc4b to
841725f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #6149 by removing two more hardcoded references to
masterthat I discovered.Originally I assumed we'd need to flip these to
HEAD, but in #6149 we were able to get away with simply removing the hardcoded reference altogether in thebundlerecosystem and we haven't seen any ill effects the past 6 months...So let's try removing this and see if it works as smoothly in these ecosystems as it did in the
bundlerecosystem.Fix #6202