Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect dependencies with restore property to work around NuGet bug #11727

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Mar 4, 2025

Issue found during manual log audit.

Doing direct NuGet dependency detection can run into a null reference exception in certain circumstances. See here for details.

There is a simple workaround to specify any restore property to ensure an outer evaluation exists.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 4, 2025
@brettfo brettfo force-pushed the dev/brettfo/nuget-nre-in-restore branch from 61d3011 to abf2f65 Compare March 4, 2025 22:48
@brettfo brettfo marked this pull request as ready for review March 4, 2025 23:13
@brettfo brettfo requested a review from a team as a code owner March 4, 2025 23:13
@sachin-sandhu sachin-sandhu merged commit 8717fcd into main Mar 5, 2025
79 checks passed
@sachin-sandhu sachin-sandhu deleted the dev/brettfo/nuget-nre-in-restore branch March 5, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants