Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private registry error handling. #11724

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Private registry error handling. #11724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/registry_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ def first_registry_with_dependency_details
headers: auth_header_for(details["token"])
)
response.status < 400 && JSON.parse(response.body)
if response.status >= 400
raise DependencyFileNotResolvable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you dig into where known_registries is set? It should only be a private registry if a private registry is set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is,
image

However, I see that a fallback logic has been implemented by @jakecoffman (see line 102). That's why I requested his review on these changes.

image

"Response status from the `#{details["registry"]}` registry: #{response.status}"
end
rescue Excon::Error::Timeout,
Excon::Error::Socket,
JSON::ParserError
Expand Down
Loading