use different values for $(TargetPlatformVersion) for TFM and dependency discovery
#11718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByAgenT
approved these changes
Mar 3, 2025
randhircs
force-pushed
the
dev/brettfo/nuget-os-tfm-discovery
branch
from
514d6a9 to
137ccbc
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency discovery is a two step process:
Several MSBuild properties are set to enable this to work properly for OS-specific situations, but if a value for
$(TargetPlatformVersion)is not set, there are two separate values that need to be used as a default. For scenario (1) a default value of0.0is required, but for scenario (2) a default value of1.0is required. This PR allows each stage of dependency discovery to set the appropriate value.Fixes #11719.