Make setup-go inherit go version from the go.mod file
#11717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
inherit-go-version-from-the-go-mod-file
branch
from
83e59f4 to
2306caa
Compare
JamieMagee
previously approved these changes
Mar 3, 2025
kbukum1
previously approved these changes
Mar 3, 2025
jeffwidman
force-pushed
the
inherit-go-version-from-the-go-mod-file
branch
from
2306caa to
f8ac27e
Compare
This way it's one less place we have to keep things in-sync. I realize the version in `go.mod` is intended as a minimum bound and not a hardcoded version, for example, the underlying file is already using a slightly different version: https://github.com/dependabot/dependabot-core/blob/d0b3517a63291220cbdb7b04f1f6859474fcd375/silent/tests/go.mod But practically speaking my experience is this way is simpler to reason about.
jeffwidman
force-pushed
the
inherit-go-version-from-the-go-mod-file
branch
from
f8ac27e to
e44497f
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it's one less place we have to keep things in-sync.
I realize the version in
go.modis intended as a minimum bound and not a hardcoded version, for example, the underlying file is already using a slightly different version:https://github.com/dependabot/dependabot-core/blob/d0b3517a63291220cbdb7b04f1f6859474fcd375/silent/tests/go.mod
But practically speaking my experience is this way is simpler to reason about.