Document why bundler-cache: true isn't needed
#11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
approved these changes
Mar 3, 2025
kbukum1
approved these changes
Mar 4, 2025
I was about to add `bundler-cache: true` when I realized that we don't actually `bundle install` anything. So the cache is not only superfluous, it's probably slower. Since I spent a little bit of time digging into this and it's easy to miss if someone is in a hurry, I thought best to document for the next person. Hopefully this way if someone changes to `bundle install` a gem, they'll realize this should get flipped on.
jeffwidman
force-pushed
the
document-why-bump-version-workflow-doesnt-bundler-cache
branch
from
b3603b2 to
011f786
Compare
jeffwidman
deleted the
document-why-bump-version-workflow-doesnt-bundler-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to add
bundler-cache: truewhen I realized that we don't actuallybundle installanything. So the cache is not only superfluous, it's probably slower.Since I spent a little bit of time digging into this and it's easy to miss if someone is in a hurry, I thought best to document for the next person.
Hopefully this way if someone changes to
bundle installa gem, they'll realize this should get flipped on.