Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sorbet type strict for the metadata_finder #11660

Merged
merged 10 commits into from
Mar 3, 2025
Merged

Added sorbet type strict for the metadata_finder #11660

merged 10 commits into from
Mar 3, 2025

Conversation

randhircs
Copy link
Member

@randhircs randhircs commented Feb 21, 2025 •
edited
Loading

What are you trying to accomplish?

Sorbet Type as strict for the metadata_finder

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@randhircs randhircs requested a review from a team as a code owner February 21, 2025 21:41
@randhircs randhircs self-assigned this Feb 21, 2025
@randhircs randhircs added sorbet 🍦 Relates to Sorbet types and removed L: python labels Feb 21, 2025
@randhircs randhircs force-pushed the randhircs/dependabot_core_sorbettype_check branch from 43dfb6d to 918f213 Compare February 21, 2025 21:42
@randhircs randhircs force-pushed the randhircs/dependabot_core_sorbettype_check branch from f5bdcbb to 3c7f60b Compare February 26, 2025 21:26
abdulapopoola
abdulapopoola reviewed Feb 26, 2025
View reviewed changes
python/lib/dependabot/python/metadata_finder.rb Outdated
MAIN_PYPI_URL = "https://pypi.org/pypi"

sig { returns(T.untyped) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why this is untyped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulapopoola I was getting some other error, now that is fixed and this return type is also changed now.

@JamieMagee JamieMagee force-pushed the randhircs/dependabot_core_sorbettype_check branch from 0797fff to fa9bb19 Compare February 28, 2025 22:41
JamieMagee
JamieMagee previously approved these changes Feb 28, 2025
View reviewed changes
@JamieMagee JamieMagee force-pushed the randhircs/dependabot_core_sorbettype_check branch from fa9bb19 to a956eca Compare February 28, 2025 22:44
JamieMagee
JamieMagee previously approved these changes Feb 28, 2025
View reviewed changes
@randhircs randhircs force-pushed the randhircs/dependabot_core_sorbettype_check branch from 01dc304 to 6d660b2 Compare February 28, 2025 23:39
@randhircs randhircs merged commit 9c44da9 into main Mar 3, 2025
68 checks passed
@randhircs randhircs deleted the randhircs/dependabot_core_sorbettype_check branch March 3, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markhallen markhallen markhallen approved these changes

@JamieMagee JamieMagee JamieMagee left review comments

@abdulapopoola abdulapopoola Awaiting requested review from abdulapopoola

Assignees

@randhircs randhircs

Labels
L: python sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@randhircs @markhallen @abdulapopoola @JamieMagee @kbukum1