feat: JS Clients can read constituent data in unaggregated columns #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
jsapi
NoDocumentationNeeded
ReleaseNotesNeeded
mofojed
reviewed
Feb 27, 2025
mofojed
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
A minor nitpick for cleanup.
Tested with a few different tables:
from deephaven import agg, empty_table, ui
from deephaven.plot import express as dx
stocks = dx.data.stocks()
r = stocks.rollup(aggs=agg.sum_(["Price"]), by=["Sym", "Exchange"], include_constituents=True)
r2 = stocks.rollup(aggs=agg.sum_(["Price"]), by=["Sym", "Exchange"], include_constituents=False)
r3 = stocks.view(["Sym", "Exchange", "Size"]).rollup(aggs=agg.sum_(["Price"]), by=["Sym", "Exchange"], include_constituents=True)| constituentColumns.put(column.getName(), column); | ||
| } else { | ||
| columns[columns.length] = column; | ||
| if (definition.isRollupGroupByColumn() && !definition.isRollupConstituentNodeColumn()) { |
There was a problem hiding this comment.
No need for the && !definition.isRollupConstituentNodeColumn(), as that's always true in this else block
Suggested change
| if (definition.isRollupGroupByColumn() && !definition.isRollupConstituentNodeColumn()) { | |
| if (definition.isRollupGroupByColumn()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constituent columns are available for snapshot by the server, but the JS API until now has not made them available to users. This patch exposes those columns as part of the
dh.TreeTableobject, and allows them to be subscribed to.Fixes DH-18431
Fixes #3303