Simplify New()

dedis · Apr 2, 2024 · e32d4a5 · e32d4a5
1 parent fbc9328
commit e32d4a5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 20 deletions.
diff --git a/xof/blake2xb/blake.go b/xof/blake2xb/blake.go
@@ -29,18 +29,15 @@ func New(seed []byte) kyber.XOF {
 		panic("blake2b.NewXOF should not return error: " + err.Error())
 	}
 
-	if seed2 != nil {
-		_, err := b.Write(seed2)
-		if err != nil {
-			panic("blake2b.XOF.Write should not return error: " + err.Error())
-		}
-
-		seedCopy := make([]byte, len(seed2))
-		copy(seedCopy, seed2)
-		seed2 = seedCopy
+	_, err = b.Write(seed2)
+	if err != nil {
+		panic("blake2b.XOF.Write should not return error: " + err.Error())
 	}
 
-	return &xof{impl: b, seed: seed2}
+	seedCopy := make([]byte, len(seed2))
+	copy(seedCopy, seed2)
+
+	return &xof{impl: b, seed: seedCopy}
 }
 
 func (x *xof) Clone() kyber.XOF {

diff --git a/xof/blake2xs/blake.go b/xof/blake2xs/blake.go
@@ -29,18 +29,15 @@ func New(seed []byte) kyber.XOF {
 		panic("blake2s.NewXOF should not return error: " + err.Error())
 	}
 
-	if seed2 != nil {
-		_, err := b.Write(seed2)
-		if err != nil {
-			panic("blake2s.XOF.Write should not return error: " + err.Error())
-		}
-
-		seedCopy := make([]byte, len(seed2))
-		copy(seedCopy, seed2)
-		seed2 = seedCopy
+	_, err = b.Write(seed2)
+	if err != nil {
+		panic("blake2s.XOF.Write should not return error: " + err.Error())
 	}
 
-	return &xof{impl: b, seed: seed2}
+	seedCopy := make([]byte, len(seed2))
+	copy(seedCopy, seed2)
+
+	return &xof{impl: b, seed: seedCopy}
 }
 
 func (x *xof) Clone() kyber.XOF {